Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default Python 3 interpreter, when precise minor version is not specified to gradle. #31282

Closed
wants to merge 4 commits into from

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented May 13, 2024

No description provided.

@tvalentyn tvalentyn changed the title Use default Python 3 interpreter, when precise minor version is not s… Use default Python 3 interpreter, when precise minor version is not specified. May 13, 2024
@github-actions github-actions bot added the build label May 13, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.41%. Comparing base (45c730a) to head (5e67ca3).
Report is 25 commits behind head on master.

❗ Current head 5e67ca3 differs from pull request most recent head 2004da6. Consider uploading reports for the commit 2004da6 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #31282       +/-   ##
=============================================
+ Coverage     56.87%   71.41%   +14.54%     
  Complexity     1474     1474               
=============================================
  Files           502      909      +407     
  Lines         46300   113707    +67407     
  Branches       1076     1076               
=============================================
+ Hits          26334    81209    +54875     
- Misses        17947    30479    +12532     
  Partials       2019     2019               
Flag Coverage Δ
python 81.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvalentyn
Copy link
Contributor Author

tvalentyn commented May 14, 2024

Python 3.11 tests ML tests are failing due to: #31287. We need to fix that too but it is not related to this change.

@tvalentyn tvalentyn requested a review from damccorm May 14, 2024 16:40
@tvalentyn tvalentyn marked this pull request as ready for review May 14, 2024 16:40
@tvalentyn tvalentyn changed the title Use default Python 3 interpreter, when precise minor version is not specified. Use default Python 3 interpreter, when precise minor version is not specified to gradle. May 14, 2024
@tvalentyn
Copy link
Contributor Author

noting that all tests except https://github.com/apache/beam/actions/runs/9071465904/job/24956302074?pr=31282 passed, adding a fix for that suite now.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvalentyn
Copy link
Contributor Author

hmm, now two more ML suites are failing. Will check if this a new error first.

@tvalentyn tvalentyn marked this pull request as draft May 14, 2024 18:01
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 14, 2024
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants