Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.12 python hinting errors on MacOS #31246

Merged
merged 2 commits into from
May 10, 2024
Merged

Fix Python 3.12 python hinting errors on MacOS #31246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38498ac
Fix typo in Intrinsic Operations test
jrmccluskey May 10, 2024
8702cef
Fix load_fast_and_clear
jrmccluskey May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sdks/python/apache_beam/typehints/intrinsic_one_ops_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ class IntrinsicOneOpsTest(unittest.TestCase):
def test_unary_intrinsic_ops_are_in_the_same_order_as_in_cpython(self):
if sys.version_info >= (3, 12):
dis_order = dis.__dict__['_intrinsic_1_descs']
beam_ops = [fn.__name_upper() for fn in intrinsic_one_ops.INT_ONE_OPS]
for fn in intrinsic_one_ops.INT_ONE_OPS:
beam_ops.append(fn.__name__.upper())
beam_ops = [fn.__name__.upper() for fn in intrinsic_one_ops.INT_ONE_OPS]
self.assertListEqual(dis_order, beam_ops)


Expand Down
2 changes: 1 addition & 1 deletion sdks/python/apache_beam/typehints/opcodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ def load_fast(state, arg):

def load_fast_and_clear(state, arg):
state.stack.append(state.vars[arg])
del state.vars[arg]
state.vars[arg] = None


def store_fast(state, arg):
Expand Down
Loading