Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a deprecated test helper. #31236

Merged
merged 2 commits into from
May 10, 2024
Merged

Remove a deprecated test helper. #31236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d71dd0b
Remove a deprecated test helper.
tvalentyn May 9, 2024
b91cc5e
yapf
tvalentyn May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/python/apache_beam/options/pipeline_options_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def test_display_data(self, flags, _, display_data):
@parameterized.expand(TEST_CASES)
def test_get_all_options_subclass(self, flags, expected, _):
options = PipelineOptionsTest.MockOptions(flags=flags)
self.assertDictContainsSubset(expected, options.get_all_options())
self.assertLessEqual(expected.items(), options.get_all_options().items())
self.assertEqual(
options.view_as(PipelineOptionsTest.MockOptions).mock_flag,
expected['mock_flag'])
Expand All @@ -219,7 +219,7 @@ def test_get_all_options_subclass(self, flags, expected, _):
@parameterized.expand(TEST_CASES)
def test_get_all_options(self, flags, expected, _):
options = PipelineOptions(flags=flags)
self.assertDictContainsSubset(expected, options.get_all_options())
self.assertLessEqual(expected.items(), options.get_all_options().items())
self.assertEqual(
options.view_as(PipelineOptionsTest.MockOptions).mock_flag,
expected['mock_flag'])
Expand Down
5 changes: 3 additions & 2 deletions sdks/python/apache_beam/testing/test_pipeline_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ def test_empty_option_args_parsing(self):
def test_create_test_pipeline_options(self):
test_pipeline = TestPipeline(argv=self.TEST_CASE['options'])
test_options = PipelineOptions(test_pipeline.get_full_options_as_args())
self.assertDictContainsSubset(
self.TEST_CASE['expected_dict'], test_options.get_all_options())
self.assertLessEqual(
self.TEST_CASE['expected_dict'].items(),
test_options.get_all_options().items())

EXTRA_OPT_CASES = [{
'options': {
Expand Down
Loading