Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging loading filesystems failures. #31219

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

RyuSA
Copy link
Contributor

@RyuSA RyuSA commented May 8, 2024

Please add a meaningful description for your change here

fixes #31218

This PR contains these changes;

  • Added a new error handling for ModuleNotFoundError
    • no logging
  • Changed the error handling for ImportError
    • logging warn log with the exception to identify any issues around import.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented May 8, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

tvalentyn commented May 8, 2024

Thanks, @RyuSA ! @Abacn had some suggestions about the proposal, so passing to @Abacn for review. Re formatter & lint errors: see: s.apache.org/beam-python-dev-wiki for pointers on linters and yapf. You can find information about error logs by clicking "Details".

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. It looks good to me. The scenario of missing dependency could be a separate change. For now please find @tvalentyn 's comment about resolving formatting issue

sdks/python/apache_beam/io/filesystems.py Show resolved Hide resolved
Copy link
Contributor

Reminder, please take a look at this pr: @tvalentyn @chamikaramj

@Abacn Abacn merged commit 1a52285 into apache:master May 21, 2024
77 checks passed
@RyuSA RyuSA deleted the feature-31218 branch May 22, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Enhance Error Handling in FileSystem Imports to Improve Troubleshooting
3 participants