Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 support #30828

Merged
merged 9 commits into from
May 23, 2024
Merged

Add Python 3.12 support #30828

merged 9 commits into from
May 23, 2024

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Apr 2, 2024

Adds support for Python 3.12.0

fixes: #29149

Some Python PostCommit GHA test results from a branch created against Apache Repo :

future work:

  • move version configuration in GHA matrices into a common configuration file (deferred for now to allow more time to run the tests against before the release cut.)

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tvalentyn tvalentyn requested a review from damccorm May 22, 2024 21:35
@@ -296,7 +296,7 @@ commands =
/bin/sh -c 'pytest -o junit_suite_name={envname} --junitxml=pytest_{envname}.xml -n 6 -m uses_pyarrow {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'


[testenv:py{38,39,310,311}-pandas-{14,15,20}]
[testenv:py{38,39}-pandas-{14,15,20}]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I removed 310/311 python versions from some configurations since we don't have any tests that exercise these configurations. We might be upgrading to Python 3.9 soon, so left that for now.

@tvalentyn tvalentyn requested a review from riteshghorse May 23, 2024 16:16
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just had minor comments

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending one open thread)

@tvalentyn tvalentyn merged commit dc6b72c into apache:master May 23, 2024
85 checks passed
@tvalentyn tvalentyn deleted the py312 branch May 23, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Support Python 3.12
2 participants