Updates the test suite to use the transform service #30605
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
LGTM on code change in python |
| } | ||
|
|
||
| // We only try to install dependencies, if the requirements file exists. | ||
| if dependencies_requirements_file_exists { |
There was a problem hiding this comment.
The indentation here seems off, this should be in line with the comment, right?
Non-blocking for this PR, but seems like we should catch this with a go fmt check. It would be good to bring all the boot.go files under
beam/.github/workflows/go_tests.yml
Line 61 in 986f67f
There was a problem hiding this comment.
For this pr, could you run go fmt boot.go
There was a problem hiding this comment.
Lets add content here and check it in like 97f8dae for consistency
| } | ||
|
|
||
| // We only try to install dependencies, if the requirements file exists. | ||
| if dependencies_requirements_file_exists { |
* Updates the test suite to use the transform service * Trigger the test suite * Fix formatting * Addressing reviewer comments
Tests passes after #30491 but they are not actually using the Transform Service (using a jar-based expansion service instead).
This updates the tests to use the Transform Service. Also fixes an issue that causes the test suite to fail originally.
This fixes #30238.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.