fix playground backend container builds #30497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @damccorm please check the comments i left in the description to understand some of the decisions made here |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Is Playground PreCommit failure related to this change? |
|
No, seems like a test failure, that part of code was not touched |
|
Agreed this is unrelated to precommit failure (looks like a go lint issue for a dependency, which is odd) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes python backend container build issue. After update to debian bookworm openjdk-11-jre-headless package is no longer availabile in stable. Fix downloads the package from bullseye repo and uses apt to install. This was chosen instead of adding bullseye as oldstable to avoid package conflicts. There was an option to update to openjdk-17 but was not sure if playground code would be affected.
Fixes java container build where for some reason maven uses offline mode when doing
dependency:list. Instead of removing offline (it was there for some reason) we just addmvn dependency:go-offlineto preload the needed dependenciesThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.