Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the TransformService test suite not pass trivially. #30491

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Make the TransformService test suite not pass trivially. #30491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2890,7 +2890,8 @@ class BeamModulePlugin implements Plugin<Project> {
def cmdArgs = project.project(':sdks:python').mapToArgString(beamPythonTestPipelineOptions)

project.exec {
environment "EXPANSION_PORT", externalPort
Abacn marked this conversation as resolved.
Show resolved Hide resolved
// Following env variable has to be set to make sure that the tests do not pass trivially.
environment "TRANSFORM_SERVICE_PORT", externalPort
executable 'sh'
args '-c', ". $envDir/bin/activate && cd $pythonDir && ./scripts/run_integration_test.sh $cmdArgs"
}
Expand Down
14 changes: 8 additions & 6 deletions sdks/python/apache_beam/io/gcp/bigtableio_it_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@ def instance_prefix(instance):
@pytest.mark.uses_transform_service
@unittest.skipIf(client is None, 'Bigtable dependencies are not installed')
@unittest.skipUnless(
os.environ.get('EXPANSION_JARS'),
"EXPANSION_JARS environment var is not provided, "
"indicating that jars have not been built")
os.environ.get('EXPANSION_JARS') or
os.environ.get('TRANSFORM_SERVICE_PORT'),
"A valid expansion service is not available for executing the "
"cross-language test.")
class TestReadFromBigTableIT(unittest.TestCase):
INSTANCE = "bt-read-tests"
TABLE_ID = "test-table"
Expand Down Expand Up @@ -151,9 +152,10 @@ def test_read_xlang(self):
@pytest.mark.uses_transform_service
@unittest.skipIf(client is None, 'Bigtable dependencies are not installed')
@unittest.skipUnless(
os.environ.get('EXPANSION_JARS'),
"EXPANSION_JARS environment var is not provided, "
"indicating that jars have not been built")
os.environ.get('EXPANSION_JARS') or
os.environ.get('TRANSFORM_SERVICE_PORT'),
"A valid expansion service is not available for executing the "
"cross-language test.")
class TestWriteToBigtableXlangIT(unittest.TestCase):
# These are integration tests for the cross-language write transform.
INSTANCE = "bt-write-xlang"
Expand Down
Loading