Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle a user whose account was deleted. #30192

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Handle a user whose account was deleted. #30192

merged 2 commits into from
Feb 5, 2024

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Feb 2, 2024

One of PR Bot workflows is failing because the PR #29347 has a comment from a now-deleted account.

Attempting to fix this in this PR.

https://github.com/apache/beam/actions/runs/7602366264/job/20702841060

Processing PR 29347
/runner/_work/beam/beam/scripts/ci/pr-bot/lib/updateReviewers.js:93
            if (comment.user.login &&
                             ^

TypeError: Cannot read properties of null (reading 'login')
    at /runner/_work/beam/beam/scripts/ci/pr-bot/lib/updateReviewers.js:93:30
    at Generator.next (<anonymous>)
    at fulfilled (/runner/_work/beam/beam/scripts/ci/pr-bot/lib/updateReviewers.js:22:58)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: Process completed with exit code 1.

@github-actions github-actions bot added the infra label Feb 2, 2024
@tvalentyn
Copy link
Contributor Author

R: @Abacn

@tvalentyn
Copy link
Contributor Author

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor

Abacn commented Feb 2, 2024

CC: @shunping

@tvalentyn tvalentyn requested a review from Abacn February 2, 2024 18:27
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@tvalentyn tvalentyn merged commit d5aa44c into master Feb 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants