Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/apache/beam/actions/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml #30065

Closed
wants to merge 7 commits into from

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Jan 22, 2024

This brings these tasks in line with their underlying docker tasks (

name containerImageName(
and
name containerImageName(
).

Previously this task was permared with these errors: https://github.com/apache/beam/actions/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml

Example run with my changes: https://github.com/apache/beam/actions/runs/7617714675

Fixes #28339


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jan 22, 2024
@damccorm damccorm closed this Jan 30, 2024
@damccorm damccorm deleted the users/damccorm/dockerFix branch January 30, 2024 14:44
@tvalentyn
Copy link
Contributor

was this closed by accident or the approach so far doesn't work?

@damccorm
Copy link
Contributor Author

damccorm commented Feb 2, 2024

was this closed by accident or the approach so far doesn't work?

The approach so far hasn't worked and I didn't have the bandwidth to take it forward. I may reopen it at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing "beam_PostCommit_XVR_GoUsingJava_Dataflow" job
2 participants