-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prism] Add fusion. #29306
[prism] Add fusion. #29306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29306 +/- ##
==========================================
+ Coverage 38.30% 38.32% +0.01%
==========================================
Files 690 690
Lines 102048 102123 +75
==========================================
+ Hits 39088 39135 +47
- Misses 61378 61402 +24
- Partials 1582 1586 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the detailed description!
Co-authored-by: Ritesh Ghorse <[email protected]>
Add robust fusion heuristics to Prism's graph Pre-processing, leading to improved performance when it's enabled. In this PR it's enabled by default, but in a subsequent PR, it'll be enabled by default in the stand alone command, and generally all variants except the "test" variant.
Minor fixes:
Note: This can be improved if we add "Flatten Unnzipping/Sinking" where Flattens can be removed from the graph, and executed implicitly. It's a more elaborate graph transformation however, since it involves duplicating downstream transforms, and allowing PCollections to have multiple producers. For now, we ignore SDK side flattens (which are only sometimes permittable), and force Runner side flattens to not be fused, since runner side transforms can't fuse at this time.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.