Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staging java source/python source #29299

Merged
merged 15 commits into from
Nov 5, 2023
Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Nov 3, 2023

Both these workflows were failing. The java source was accidentally modified as part of the pyproject.toml work, this reverts it back to its previous state. The python source never worked and had a bunch of issues that needed fixing.

Example successful workflow - https://github.com/apache/beam/actions/runs/6754402902/job/18361839573


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #29299 (50c1522) into master (f25c441) will decrease coverage by 0.01%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #29299      +/-   ##
==========================================
- Coverage   38.30%   38.30%   -0.01%     
==========================================
  Files         690      690              
  Lines      102045   102048       +3     
==========================================
  Hits        39085    39085              
- Misses      61377    61380       +3     
  Partials     1583     1583              
Flag Coverage Δ
python 29.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@damccorm damccorm changed the title [WIP] Fix staging java source/python source Fix staging java source/python source Nov 4, 2023
@damccorm damccorm marked this pull request as ready for review November 4, 2023 10:58
Copy link
Contributor

github-actions bot commented Nov 4, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@damccorm damccorm merged commit e612060 into master Nov 5, 2023
72 of 74 checks passed
@damccorm damccorm deleted the users/damccorm/fix-rc-build branch November 5, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants