Use MillisInstant by default when Python JdbcIO is used #29182
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve https://stackoverflow.com/questions/77317904/apache-beam-python-sdk-reading-from-postgres-using-jdbc-io
Some context:
This has been a long-standing issue. MillisInstant is a logical type that backs Java's DATETIME type in schema (in Java side, its language type is a Joda Instant). In Beam portable framework, DATETIME is no longer a primitive type (true for Python, Go but not for Java), but rather a logical type backed by a MicrosInstant. Its language type is a Java.time.Instant (due to joda is in maintenance mode and there is plan to replace to java.time.Instant.
This would be a breaking change and milestoned at next major version). As such, Java SDK still uses DATETIME primitive in schema. MillisInstant logical type was then a workaround introduced, to enable Python xlang JdbcIO to r/w rows contain Timestamps. But it need to register the MillisInstant to overwrite the default mapping (MicrosInstant) --- That is what currently the integration does.
Since this has been a pain point. It may worth to include this line in the jdbc module. It will then make the MillisInstant supersedes MicrosInstant when jdbc module is imported.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.