Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra typehinting tests #29148

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Add extra typehinting tests #29148

merged 4 commits into from
Oct 27, 2023

Conversation

jrmccluskey
Copy link
Contributor

Adds some extra tests around enumeration type hinting in collections, also covers the built-in frozensetcase that didn't have a test.

Part of #29135


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #29148 (9c40601) into master (8b8af7f) will not change coverage.
Report is 17 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #29148   +/-   ##
=======================================
  Coverage   38.36%   38.36%           
=======================================
  Files         687      687           
  Lines      101741   101741           
=======================================
  Hits        39033    39033           
  Misses      61128    61128           
  Partials     1580     1580           
Flag Coverage Δ
python 29.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jrmccluskey
Copy link
Contributor Author

R: @damccorm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one nit

@jrmccluskey
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@jrmccluskey
Copy link
Contributor Author

Run Python_Transforms PreCommit

@jrmccluskey
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

1 similar comment
@jrmccluskey
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@jrmccluskey jrmccluskey merged commit 7b38f74 into apache:master Oct 27, 2023
74 checks passed
@jrmccluskey jrmccluskey deleted the enumTests branch October 27, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants