-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra typehinting tests #29148
Add extra typehinting tests #29148
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29148 +/- ##
=======================================
Coverage 38.36% 38.36%
=======================================
Files 687 687
Lines 101741 101741
=======================================
Hits 39033 39033
Misses 61128 61128
Partials 1580 1580
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one nit
…st.py Co-authored-by: Danny McCormick <[email protected]>
Run Python_PVR_Flink PreCommit |
Run Python_Transforms PreCommit |
Run Python_PVR_Flink PreCommit |
1 similar comment
Run Python_PVR_Flink PreCommit |
Adds some extra tests around enumeration type hinting in collections, also covers the built-in
frozenset
case that didn't have a test.Part of #29135
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.