Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] Java Filter and explode operations. #29110

Merged
merged 14 commits into from
Nov 1, 2023

Conversation

robertwb
Copy link
Contributor

This is a follow-up on top of #28657


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@Polber Polber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should probably wait until #28657 is merged to make sure there are no conflicts

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #29110 (b0867b1) into master (b513420) will decrease coverage by 0.01%.
Report is 10 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head b0867b1 differs from pull request most recent head e33f510. Consider uploading reports for the commit e33f510 to get more accurate results

@@            Coverage Diff             @@
##           master   #29110      +/-   ##
==========================================
- Coverage   38.32%   38.32%   -0.01%     
==========================================
  Files         688      688              
  Lines      101843   101862      +19     
==========================================
+ Hits        39035    39041       +6     
- Misses      61228    61241      +13     
  Partials     1580     1580              
Flag Coverage Δ
python 29.93% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/yaml/yaml_mapping.py 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@robertwb robertwb merged commit 0d478da into apache:master Nov 1, 2023
83 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants