[Python]change extension of beam sdist from .zip to .tar.gz #29108
Conversation
| @@ -17,14 +17,14 @@ | |||
|
|
|||
There was a problem hiding this comment.
This file has lots of whitespaces. My IDE automatically removes them.
Codecov Report
@@ Coverage Diff @@
## master #29108 +/- ##
=======================================
Coverage 38.37% 38.37%
=======================================
Files 686 686
Lines 101685 101685
=======================================
Hits 39021 39021
Misses 61085 61085
Partials 1579 1579
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Please update documentation on https://cwiki.apache.org/confluence/display/BEAM/Python+Tips as well. |
| @@ -97,7 +97,7 @@ function download_files() { | |||
|
|
|||
| wget -r -l2 --no-parent -nd -A "$BEAM_PYTHON_SDK_WHL*" $RC_STAGING_URL | |||
| else | |||
| BEAM_PYTHON_SDK_ZIP="apache-beam-$VERSION.zip" | |||
| BEAM_PYTHON_SDK_ZIP="apache-beam-$VERSION.tar.gz" | |||
There was a problem hiding this comment.
This should be renamed
I ran https://github.com/apache/beam/actions/runs/6616347730/job/17970424418 which publishes snapshot. It was not finding the target file before but with this change it works. @jrmccluskey Do you have any github actions in mind we could run for testing purposes? |
Done |
|
@jrmccluskey @AnandInguva what are next steps here? We should prioritize this one since its a release blocker and ideally would be in before wednesday |
|
I think, based on the conversations we've had, this is fine to get in now. Just re-running that failed Go PreCommit |
Fixes: #28629
#28385 changed the sdist extension from
ziptotar.gz. Zip tarballs are not supported according to https://peps.python.org/pep-0517/#source-distributionsThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.