[flink] Flush buffer during drain operation for requiresStableInput operator #29102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
R: @je-ik I have addressed the comments. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Can you please mention the issue in the commit message? You can see other commit messages for reference. I'll merge this right after that. Thanks a lot! |
je-ik
reviewed
Oct 23, 2023
website/www/site/layouts/shortcodes/flink_python_pipeline_options.html
Outdated
Show resolved
Hide resolved
website/www/site/layouts/shortcodes/flink_python_pipeline_options.html
Outdated
Show resolved
Hide resolved
website/www/site/layouts/shortcodes/flink_python_pipeline_options.html
Outdated
Show resolved
Hide resolved
website/www/site/layouts/shortcodes/flink_java_pipeline_options.html
Outdated
Show resolved
Hide resolved
website/www/site/layouts/shortcodes/flink_java_pipeline_options.html
Outdated
Show resolved
Hide resolved
website/www/site/layouts/shortcodes/flink_java_pipeline_options.html
Outdated
Show resolved
Hide resolved
kkdoon
force-pushed
the
flink-stable-input-drain-bug2
branch
from
e35eebe to
1a27d2c
Compare
could you check if it looks ok now? Thanks! |
je-ik
approved these changes
Oct 24, 2023
|
Closes #28554. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, drain operation does not work for flink pipelines when RequiresStableInput annotation is used. This is caused by buffered data not being processed before the final checkpoint operation that causes watermark hold related exception. This PR addresses this issue by processing the buffer before the final checkpoint completes. More context in #28554.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.