Clean up IO PreCommit build configs #29097
Conversation
|
R: @damondouglas for rrio |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Abacn
force-pushed
the
cleanupiobuildconfig
branch
from
01c4148 to
71fbeeb
Compare
Abacn
force-pushed
the
cleanupiobuildconfig
branch
from
71fbeeb to
78fb0bb
Compare
| @@ -294,7 +294,6 @@ tasks.register("javaPreCommit") { | |||
| dependsOn(":sdks:java:fn-execution:build") | |||
| dependsOn(":sdks:java:harness:build") | |||
| dependsOn(":sdks:java:harness:jmh:build") | |||
| dependsOn(":sdks:java:io:azure:build") | |||
There was a problem hiding this comment.
this is already covered by beam_PreCommit_Java_Azure_IO_Direct that triggers for common trigger paths (e.g. java/core) so remove it from here.
| @@ -294,7 +294,6 @@ tasks.register("javaPreCommit") { | |||
| dependsOn(":sdks:java:fn-execution:build") | |||
| dependsOn(":sdks:java:harness:build") | |||
| dependsOn(":sdks:java:harness:jmh:build") | |||
| dependsOn(":sdks:java:io:azure:build") | |||
| dependsOn(":sdks:java:io:bigquery-io-perf-tests:build") | |||
| dependsOn(":sdks:java:io:common:build") | |||
| dependsOn(":sdks:java:io:contextualtextio:build") | |||
There was a problem hiding this comment.
there are still a couple of IO tests triggered in the large java precommit. Checked that these are not belong to specific IO PreCommit. We should move them / create new precommits as a follow up.
There was a problem hiding this comment.
this kind of bookkeeping is desirable because for now, if adding an IO connector, there is too much places to configure the test tasks and its possible to miss some of them (already happened)
|
Reduced scope. Ready for review now. R: @damondouglas this should make RRIO PreCommit working/ |
* Simplify trigger path for Java PreCommit to exclude sdks/io folder, which covered by either specific IO PreCommit for generic IO PreCommit (:javaioPreCommit)Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.