Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Setup environment actions #29026

Conversation

aleksandr-dudko
Copy link
Contributor

Add setup-environment-action to all jobs

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Oct 16, 2023
@aleksandr-dudko aleksandr-dudko force-pushed the aleksandr.dudko/bi-378-add-setup-environment-action branch from 169d632 to 96db1f7 Compare October 17, 2023 09:49
Copy link
Contributor

@andreydevyatkin andreydevyatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aleksandr-dudko aleksandr-dudko marked this pull request as ready for review October 17, 2023 15:36
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review, this looks good to me, I think standardizing on setup is a good idea. Once conflicts are resolved it should be good to merge

@andreydevyatkin
Copy link
Contributor

Sorry for the slow review, this looks good to me, I think standardizing on setup is a good idea. Once conflicts are resolved it should be good to merge

@damccorm Actually these changes are more than just standardization (lack of description for PR), I would say that it is a bonus to the actual intent. The purpose of adding the setup-environment-action action is to publish gradle snapshots - there is a baked-in gradle setup step that must be added to every workflow file.
Initially, I added the setup-environment-action step to the setup-action action in order to delay applying this change everywhere until we migrated all workflows. Now, it's time to move out this step from setup-action because they are about different meaning.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks for clarifying - either way, LGTM - thanks!

@damccorm damccorm merged commit ca96cb5 into apache:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants