Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove issue_comment trigger in most postcommit #28916

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 10, 2023

mitigate #28909

remove more issue comment trigger after #28915 - it seems after that change we still get a long queue - when mass comment script running. Removed trigger for postcommit jobs except those listed in #28426 (comment) (no Jenkins counterpart exist)

We need to redesign a scalable comment trigger for our workflows

Another path is to use another approach to trigger workflows, at least in release verification, one should be able to use github api to trigger workflows.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Oct 10, 2023
@Abacn Abacn merged commit a7abe61 into apache:master Oct 10, 2023
@Abacn Abacn deleted the removemoreissuecomment branch October 10, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants