-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python wheel staging to GitHub Actions build_release_candidate #28822
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28822 +/- ##
=======================================
Coverage 72.21% 72.21%
=======================================
Files 684 684
Lines 101235 101235
=======================================
Hits 73104 73104
Misses 26556 26556
Partials 1575 1575 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
RC_TAG: "v${{ github.event.inputs.RELEASE }}-RC${{ github.event.inputs.RC }}" | ||
GIT_REPO_BASE_URL: https://github.com/apache/beam | ||
RELEASE_DIR: "beam/${{ github.event.inputs.RELEASE }}" | ||
SCRIPT_DIR: release/src/main/scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to se the GITHUB_TOKEN here as an env var (it won't be automatically visible).
So GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also still prefer we pass the env location into the script to be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done & done
@@ -147,7 +147,72 @@ jobs: | |||
svn status | |||
svn commit -m "Staging Java artifacts for Apache Beam ${{ github.event.inputs.RELEASE }} RC${{ github.event.inputs.RC }}" --non-interactive --username ${{ github.event.inputs.APACHE_ID }} --password ${{ github.event.inputs.APACHE_PASSWORD }} | |||
|
|||
|
|||
stage_python_artifacts: | |||
if: ${{github.event.inputs.STAGE_PYTHON_SOURCE == 'yes'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add STAGE_PYTHON_SOURCE
as an input at the top of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (changed also to ARTIFACTS
since it is more than source I think.
sha512sum -c "apache-beam-${RELEASE}.zip.sha512" | ||
|
||
echo "------Signing Source Release apache-beam-${RELEASE}.zip------" | ||
gpg --local-user "${SIGNING_KEY}" --armor --detach-sig "apache-beam-${RELEASE}.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
signing_key is not assigned, you can include it as an env var using ${{steps.import_gpg.outputs.name}}
like we do above.
Also note that local-user here is actually the name of the key, not the key itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
5b18d7d
to
57821c1
Compare
This directly ports the logic in
build_release_candidate.sh
to the GitHub Action in `build_release_candidate.ymlThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.