Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype usage #28797

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix dtype usage #28797

merged 1 commit into from
Oct 4, 2023

Conversation

caneff
Copy link
Contributor

@caneff caneff commented Oct 3, 2023

Fix the way that categorical dtypes were checked. This was raising deprecation warnings.

@caneff
Copy link
Contributor Author

caneff commented Oct 3, 2023

R: @tvalentyn

@github-actions github-actions bot added the python label Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor

Run Python_Coverage PreCommit

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #28797 (1473eeb) into master (94327fd) will increase coverage by 0.01%.
Report is 114 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #28797      +/-   ##
==========================================
+ Coverage   72.23%   72.24%   +0.01%     
==========================================
  Files         684      684              
  Lines      101070   101230     +160     
==========================================
+ Hits        73003    73129     +126     
- Misses      26489    26523      +34     
  Partials     1578     1578              
Flag Coverage Δ
python 82.79% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/dataframe/frames.py 95.20% <100.00%> (-0.05%) ⬇️

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@caneff caneff marked this pull request as ready for review October 4, 2023 11:06
@caneff caneff requested a review from tvalentyn October 4, 2023 11:06
@tvalentyn tvalentyn merged commit 3cae5ad into apache:master Oct 4, 2023
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants