Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Depreciation warning when using pipeline.options #28774

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

aku019
Copy link
Contributor

@aku019 aku019 commented Oct 2, 2023

Removed the depreciation warning wherever it was been thrown.

Fixes #28236


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #28774 (af3b93f) into master (3bbfa7e) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #28774   +/-   ##
=======================================
  Coverage   72.22%   72.22%           
=======================================
  Files         684      684           
  Lines      101241   101235    -6     
=======================================
- Hits        73125    73121    -4     
+ Misses      26538    26536    -2     
  Partials     1578     1578           
Flag Coverage Δ
python 82.76% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/pipeline.py 91.85% <ø> (-0.02%) ⬇️
...pache_beam/runners/interactive/interactive_beam.py 82.22% <ø> (-0.12%) ⬇️
...eam/runners/interactive/interactive_environment.py 91.97% <ø> (-0.05%) ⬇️
...ache_beam/runners/interactive/recording_manager.py 96.55% <ø> (-0.02%) ⬇️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn
Copy link
Contributor

Thanks for your contribution, @aku019 . PTAL at lint failures. You can click on the Details link

Running pylint...
************* Module apache_beam.runners.interactive.interactive_beam
apache_beam/runners/interactive/interactive_beam.py:38:0: W0611: Unused import warnings (unused-import)
************* Module apache_beam.runners.interactive.interactive_environment
apache_beam/runners/interactive/interactive_environment.py:32:0: W0611: Unused import warnings (unused-import)

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tvalentyn tvalentyn merged commit a7bf594 into apache:master Oct 2, 2023
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Calls to pipeline.options. in Beam codebase cause unactionable deprecation warning for users.
3 participants