Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically switch to upload_graph when the graph is large #28621

Merged
merged 13 commits into from
Oct 27, 2023
Merged

Automatically switch to upload_graph when the graph is large #28621

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0f7bdf6
Automatically Switch to upload_graph when the graph is large
liferoad Sep 22, 2023
9d5214f
fix the formats
liferoad Sep 22, 2023
d0f5f79
Merge branch 'master' into upload-graph1
liferoad Sep 30, 2023
0f7184d
updated the CHANGES.md
liferoad Sep 30, 2023
74a42a2
updated the CHANGES.md
liferoad Oct 16, 2023
ab0329f
merged master
liferoad Oct 16, 2023
9d72fb2
added one test
liferoad Oct 20, 2023
51c7589
Merge branch 'master' into upload-graph1
liferoad Oct 20, 2023
56c5cc4
fixed the styles
liferoad Oct 20, 2023
b389b2a
fixed the styles
liferoad Oct 20, 2023
2498b85
fixed the styles
liferoad Oct 26, 2023
d0ab0c3
Merge branch 'master' into upload-graph1
liferoad Oct 26, 2023
8e1114b
addressed the comments
liferoad Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...le-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,6 +1331,14 @@ public DataflowPipelineJob run(Pipeline pipeline) {
hooks.modifyEnvironmentBeforeSubmission(newJob.getEnvironment());
}

// enable upload_graph when the graph is too large
if ((Utf8.encodedLength(newJob.toString()) >= CREATE_JOB_REQUEST_LIMIT_BYTES)
liferoad marked this conversation as resolved.
Show resolved Hide resolved
&& !hasExperiment(options, "upload_graph")) {
List<String> experiments = new ArrayList<>(options.getExperiments());
experiments.add("upload_graph");
options.setExperiments(ImmutableList.copyOf(experiments));
}

// Upload the job to GCS and remove the graph object from the API call. The graph
// will be downloaded from GCS by the service.
if (hasExperiment(options, "upload_graph")) {
Expand Down