Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] Add PubSub reading and writing transforms. #28595

Merged
merged 9 commits into from
Sep 25, 2023

Conversation

robertwb
Copy link
Contributor


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #28595 (f7039fa) into master (c5e6c79) will decrease coverage by 0.01%.
Report is 34 commits behind head on master.
The diff coverage is 87.62%.

@@            Coverage Diff             @@
##           master   #28595      +/-   ##
==========================================
- Coverage   72.24%   72.24%   -0.01%     
==========================================
  Files         684      684              
  Lines      101071   101232     +161     
==========================================
+ Hits        73022    73136     +114     
- Misses      26470    26517      +47     
  Partials     1579     1579              
Flag Coverage Δ
python 82.78% <87.62%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/testing/util.py 96.79% <100.00%> (+0.08%) ⬆️
sdks/python/apache_beam/typehints/schemas.py 88.91% <100.00%> (-0.26%) ⬇️
sdks/python/apache_beam/yaml/yaml_transform.py 90.11% <100.00%> (+0.07%) ⬆️
sdks/python/apache_beam/transforms/core.py 92.70% <84.61%> (+1.16%) ⬆️
sdks/python/apache_beam/yaml/yaml_io.py 69.16% <86.84%> (+29.16%) ⬆️

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

lambda row: beam.io.gcp.pubsub.PubsubMessage(
formatter(row), attributes_extractor(row)))
| beam.io.WriteToPubSub(
topic, with_attributes=True, timestamp_attribute=timestamp_attribute))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly, id_label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@liferoad
Copy link
Contributor

LGTM. Please fix the failed tests before merging.

@robertwb robertwb merged commit 49ad65c into apache:master Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants