Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript changes for Beam 2.51.0 #28553

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Typescript changes for Beam 2.51.0 #28553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
005b166
Revert dependbot changes.
robertwb Sep 20, 2023
fa32b02
Add needed dataflow experiments.
robertwb Sep 20, 2023
80f6325
Pin to patch version.
robertwb Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
238 changes: 18 additions & 220 deletions sdks/typescript/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions sdks/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
},
"dependencies": {
"@google-cloud/pubsub": "^2.19.4",
"@grpc/grpc-js": "^1.8.8",
"@grpc/grpc-js": "~1.4.6",
"@protobuf-ts/grpc-transport": "^2.1.0",
"@protobuf-ts/plugin": "^2.1.0",
"bson": "^4.6.0",
Expand All @@ -46,7 +46,7 @@
"fast-deep-equal": "^3.1.3",
"find-git-root": "^1.0.4",
"long": "^4.0.0",
"protobufjs": "^7.2.4",
"protobufjs": "~6.11.3",
"queue-typescript": "^1.0.1",
"serialize-closures": "^0.2.7",
"ts-closure-transform": "^0.1.7",
Expand Down
2 changes: 2 additions & 0 deletions sdks/typescript/src/apache_beam/runners/dataflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ export function dataflowRunner(runnerOptions: {
options: Object = {}
): Promise<PipelineResult> {
var augmentedOptions = { experiments: [] as string[], ...options };
augmentedOptions.experiments.push("use_runner_v2");
augmentedOptions.experiments.push("use_portable_job_submission");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would typescript tests have caught this? If yes, should we add python runner paths to the workflow trigger so that the tests run against python dataflow runner changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the TypeScript Dataflow Tests should have caught this, but it's not generally run due to lack of credentials.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's not generally run due to lack of credentials.

Not sure what this means - https://github.com/apache/beam/actions/workflows/typescript_tests.yml looks like its running consistently

augmentedOptions.experiments.push("use_sibling_sdk_workers");
return new PortableRunner(
runnerOptions as any,
Expand Down