Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup jobs #28528

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Cleanup jobs #28528

merged 1 commit into from
Sep 21, 2023

Conversation

volatilemolotov
Copy link
Contributor

adds

  • beam_CleanUpGCPResources
  • beam_CleanUpPrebuiltSDKImages

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 19, 2023
@volatilemolotov volatilemolotov marked this pull request as draft September 19, 2023 13:41
runs-on: [self-hosted, ubuntu-20.04, main]
timeout-minutes: 120
strategy:
fail-fast: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is redundant since there are no other jobs to run

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved. thanks

beam_CleanUpGCPResources:
name: ${{matrix.job_name}} (${{matrix.job_phrase}})
runs-on: [self-hosted, ubuntu-20.04, main]
timeout-minutes: 120
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no explicitly specified job timeout, it should be 100 by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

issue_comment:
types: [created]
schedule:
- cron: '* */6 * * *'
Copy link
Collaborator

@andreydevyatkin andreydevyatkin Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be triggered once per day. Should be something like this: 0 0 * * *

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

issue_comment:
types: [created]
schedule:
- cron: '0 */23 * * *'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be triggered once per day. Should be something like this: 0 0 * * *

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

runs-on: [self-hosted, ubuntu-20.04, main]
timeout-minutes: 120
strategy:
fail-fast: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

beam_CleanUpPrebuiltSDKImages:
name: ${{matrix.job_name}} (${{matrix.job_phrase}})
runs-on: [self-hosted, ubuntu-20.04, main]
timeout-minutes: 120
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Thanks for taking a look

@volatilemolotov volatilemolotov marked this pull request as ready for review September 20, 2023 20:32
@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@volatilemolotov
Copy link
Contributor Author

assign set of reviewers

@volatilemolotov
Copy link
Contributor Author

@damccorm @Abacn This one is ok but the workflows are failing at post setup:

https://github.com/apache/beam/actions/runs/6250265622/job/16969850271?pr=28528

Any idea what might be causing this?

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor

@damccorm @Abacn This one is ok but the workflows are failing at post setup:

https://github.com/apache/beam/actions/runs/6250265622/job/16969850271?pr=28528

Any idea what might be causing this?

@volatilemolotov could you try pulling in the latest changes from master?

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we get the workflows green (I think pulling in master should do it)

@volatilemolotov
Copy link
Contributor Author

All green once master changes have been pulled in

@damccorm
Copy link
Contributor

Thanks!

@damccorm damccorm merged commit 0146a83 into apache:master Sep 21, 2023
4 checks passed
@volatilemolotov volatilemolotov deleted the cleanup_jobs branch September 21, 2023 19:09
kennknowles pushed a commit to kennknowles/beam that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants