Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment results to PR only when issue_comments #28480

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 15, 2023

address phrase triggered job visibility issue: #28320

After #28445 on every github action precommit run the action will comment to the PR (and overwrites each other). e.g. #28272 (comment)

This PR changes the behavior to comment only when the workflow is triggered by phrase (in this case the workflow does not add check to PR) - this both reduces the noise (when the status is already available in checks section) and make it easier to discover the test result from phrase trigger

Example run: Abacn#58 (comment)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 15, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Sep 15, 2023

R: @magicgoody @andreydevyatkin

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Collaborator

@andreydevyatkin andreydevyatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Abacn
Copy link
Contributor Author

Abacn commented Sep 18, 2023

Let me rebase one more time and include the change to new workflows merged between this open and now

@Abacn Abacn merged commit 3f56f65 into apache:master Sep 18, 2023
3 checks passed
@Abacn Abacn deleted the commentpr branch September 18, 2023 14:52
@Abacn
Copy link
Contributor Author

Abacn commented Sep 21, 2023

apparently this works for my fork repo but not on apache/beam - it still shows e.g.

2023-09-19 20:03:56 +0000 - publish -  INFO - There is no pull request for commit 9f0677dd2299a494e45fc0056e9571c6d620ef4f

in https://github.com/apache/beam/actions/runs/6238076552/job/16933121401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants