Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python Load Tests Combine Dataflow Batch github action #28431

Merged

Conversation

Amar3tto
Copy link
Collaborator

The following jenkins job has been migrated:

https://ci-beam.apache.org/job/beam_LoadTests_Python_Combine_Dataflow_Batch
https://ci-beam.apache.org/job/beam_LoadTests_Python_Combine_Dataflow_Batch_PR

How has it been tested?

The job has been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:

  • by adding a comment to the PR

Screenshot from 2023-09-12 19-21-49


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 13, 2023
@Amar3tto Amar3tto marked this pull request as ready for review September 13, 2023 15:11
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

run: |
CURDATE=$(date '+%m%d%H%M%S' --utc)
CURCONFIG=$(grep -v "^#.*" ./.github/workflows/load-tests-job-configs/config_Combine_Python_Batch_2GB_10b.txt | tr '\n' ' ')
CURCONFIG=$(echo "${CURCONFIG/load-tests-python-dataflow-batch-combine-1-/load-tests-python-dataflow-batch-combine-1-$CURDATE}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this 2nd echo doing (here and in other configs)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It replaces job_name substring with the "name+current date".
In .groovy it was:
def now = new Date().format("MMddHHmmss", TimeZone.getTimeZone('UTC'))
...
job_name : "load-tests-python-dataflow-batch-combine-1-${now}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an explanatory comment to this section explaining what we are doing? It is hard to gather intent from the code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Amar3tto Amar3tto force-pushed the load-tests-python-combine-github-actions branch from 2330a42 to adbac74 Compare September 21, 2023 07:22
@Amar3tto Amar3tto requested a review from damccorm September 21, 2023 07:23
@Amar3tto Amar3tto force-pushed the load-tests-python-combine-github-actions branch from adbac74 to ad0b256 Compare September 21, 2023 07:58
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 42c80fd into apache:master Sep 21, 2023
kennknowles pushed a commit to kennknowles/beam that referenced this pull request Sep 22, 2023
)

* Add Python Load Tests Combine Dataflow Batch github action

* Change cron

* Refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants