-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Workflow Replacement for Jenkins Job, beam_PostCommit_TransformService_Direct #28344
Github Workflow Replacement for Jenkins Job, beam_PostCommit_TransformService_Direct #28344
Conversation
-PcompileAndRunTestsWithJava11 \ | ||
-Pjava11Home=$JAVA_HOME_11_X64 \ | ||
-PuseWheelDistribution \ | ||
-PpythonVersion=3.8 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we need to run this Gradle task for two Python versions. You can check the log here: https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_TransformService_Direct/lastSuccessfulBuild/consoleFull
Or you can look at the Groovy file. There is the code where the steps are executed for the list of CROSS_LANGUAGE_VALIDATES_RUNNER_PYTHON_VERSIONS. This list consists of two elements: LOWEST_SUPPORTED and HIGHEST_SUPPORTED. The code can be found in the PythonTestProperties class, specifically on lines 33 and 37.
Finally, we need to add the same step but for a different version of Python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is very helpful, will add python 3.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
PR migrates Jenkins Jobs to Github Actions Workflow ".github/workflows/beam_PostCommit_TransformService_Direct.yml":
https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_TransformService_Direct/
The code has been tested on Self-hosted GKE runners ubuntu 20.04.
https://github.com/magicgoody/beam/actions/runs/6108170713
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.