Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Workflow Replacement for Jenkins Job, beam_PostCommit_TransformService_Direct #28344

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

magicgoody
Copy link
Contributor

@magicgoody magicgoody commented Sep 7, 2023

PR migrates Jenkins Jobs to Github Actions Workflow ".github/workflows/beam_PostCommit_TransformService_Direct.yml":

https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_TransformService_Direct/

The code has been tested on Self-hosted GKE runners ubuntu 20.04.

https://github.com/magicgoody/beam/actions/runs/6108170713
image


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 7, 2023
-PcompileAndRunTestsWithJava11 \
-Pjava11Home=$JAVA_HOME_11_X64 \
-PuseWheelDistribution \
-PpythonVersion=3.8 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we need to run this Gradle task for two Python versions. You can check the log here: https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_TransformService_Direct/lastSuccessfulBuild/consoleFull

Or you can look at the Groovy file. There is the code where the steps are executed for the list of CROSS_LANGUAGE_VALIDATES_RUNNER_PYTHON_VERSIONS. This list consists of two elements: LOWEST_SUPPORTED and HIGHEST_SUPPORTED. The code can be found in the PythonTestProperties class, specifically on lines 33 and 37.

Finally, we need to add the same step but for a different version of Python.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is very helpful, will add python 3.11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@magicgoody magicgoody marked this pull request as ready for review September 8, 2023 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit 4859f84 into apache:master Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants