Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Commit trigger for certain Jenkins precommit #28316

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 5, 2023

Please add a meaningful description for your change here

Commit trigger for the following precommit are disabled, as same GitHub Action workflows are running

Name Jenkins status GitHub Action status
PreCommit_PythonDocs Build Status .github/workflows/beam_PreCommit_PythonDocs.yml
PreCommit_PythonLint Build Status .github/workflows/beam_PreCommit_PythonLint.yml
PreCommit_RAT Build Status .github/workflows/beam_PreCommit_RAT.yml
PreCommit_Spotless Build Status .github/workflows/beam_PreCommit_Spotless.yml
PreCommit_Website Build Status .github/workflows/beam_PreCommit_Website.yml
PreCommit_Website_Stage_GCS Build Status PreCommit Website Stage GCS
PreCommit_Whitespace Build Status .github/workflows/beam_PreCommit_Whitespace.yml

cron jobs and phrase trigger are unaffected


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Sep 5, 2023

Run seed job

@github-actions github-actions bot added the infra label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@@ -26,7 +26,8 @@ PrecommitJobBuilder builder = new PrecommitJobBuilder(
timeoutMins: 30,
triggerPathPatterns: [
'^sdks/python/.*$',
]
],
commitTriggering: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove these entirely? We've been a good state for a while, and I don't think keeping them is getting us much. We can always revert if there's a problem (which is what we'd need to do anyways)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, done

note that left jenkins/README.md as is for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that github action phrase trigger still need adjustment and further fix, shall we hold on this or proceed with (just disable commit trigger)?

@Abacn Abacn marked this pull request as draft September 5, 2023 21:58
@Abacn
Copy link
Contributor Author

Abacn commented Sep 5, 2023

Found the phrase trigger does not work well. There are at least following problem

  • Another comment, regardless what content it is, will cancel the ongoing phrase triggered run for another job

  • If not triggered by commit, phrase triggered job won't update its status to the PR

@Abacn
Copy link
Contributor Author

Abacn commented Sep 5, 2023

Run Whitespace PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Sep 5, 2023

Run PythonDocs PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Sep 5, 2023

@Abacn Abacn mentioned this pull request Sep 5, 2023
15 tasks
@damccorm
Copy link
Contributor

damccorm commented Sep 6, 2023

If not triggered by commit, phrase triggered job won't update its status to the PR

This is probably not an issue for this set of jobs.

Another comment, regardless what content it is, will cancel the ongoing phrase triggered run for another job

I think blocking this pr on this probably makes sense

@Abacn
Copy link
Contributor Author

Abacn commented Sep 6, 2023

Run RAT PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Sep 6, 2023

irrelevant comment

@Abacn
Copy link
Contributor Author

Abacn commented Sep 12, 2023

Run PythonDocs PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Sep 12, 2023

Run Whitespace PreCommit

@github-actions github-actions bot added build and removed build labels Sep 12, 2023
@@ -19,10 +19,10 @@ on:
push:
tags: ['v*']
branches: ['master', 'release-*']
paths: ['*.md', '*.build.gradle','.github/workflows/beam_PreCommit_Whitespace.yml']
paths: ['*.md', '*.gradle', '*.gradle.kts', '.github/workflows/beam_PreCommit_Whitespace.yml']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should in sync with

from ("$rootProject.projectDir") {

@Abacn Abacn marked this pull request as ready for review September 12, 2023 14:53
@Abacn
Copy link
Contributor Author

Abacn commented Sep 12, 2023

Tested that phrase no longer cancel each other now. PTAL @damccorm

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm sending an email to the dev list as well to let everyone know this is happening.

@damccorm damccorm merged commit d371bfc into apache:master Sep 12, 2023
@Abacn Abacn deleted the disabletrigger branch September 12, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants