-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Commit trigger for certain Jenkins precommit #28316
Conversation
Run seed job |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
@@ -26,7 +26,8 @@ PrecommitJobBuilder builder = new PrecommitJobBuilder( | |||
timeoutMins: 30, | |||
triggerPathPatterns: [ | |||
'^sdks/python/.*$', | |||
] | |||
], | |||
commitTriggering: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just remove these entirely? We've been a good state for a while, and I don't think keeping them is getting us much. We can always revert if there's a problem (which is what we'd need to do anyways)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, done
note that left jenkins/README.md as is for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that github action phrase trigger still need adjustment and further fix, shall we hold on this or proceed with (just disable commit trigger)?
Found the phrase trigger does not work well. There are at least following problem
|
Run Whitespace PreCommit |
Run PythonDocs PreCommit |
|
This is probably not an issue for this set of jobs.
I think blocking this pr on this probably makes sense |
Run RAT PreCommit |
irrelevant comment |
3c01490
to
cb8c690
Compare
Run PythonDocs PreCommit |
Run Whitespace PreCommit |
@@ -19,10 +19,10 @@ on: | |||
push: | |||
tags: ['v*'] | |||
branches: ['master', 'release-*'] | |||
paths: ['*.md', '*.build.gradle','.github/workflows/beam_PreCommit_Whitespace.yml'] | |||
paths: ['*.md', '*.gradle', '*.gradle.kts', '.github/workflows/beam_PreCommit_Whitespace.yml'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should in sync with
from ("$rootProject.projectDir") { |
Tested that phrase no longer cancel each other now. PTAL @damccorm |
74d6d1c
to
cb8c690
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'm sending an email to the dev list as well to let everyone know this is happening.
Please add a meaningful description for your change here
Commit trigger for the following precommit are disabled, as same GitHub Action workflows are running
cron jobs and phrase trigger are unaffectedThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.