Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass runtime configs & variables to BeamSqlSeekableTable #28253

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Pass runtime configs & variables to BeamSqlSeekableTable #28253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c4a4ff
closing https://github.com/apache/beam/issues/28145
gabrywu Aug 31, 2023
db6c0f9
remove unsupported parameter & add parameter type to context
gabrywu Sep 1, 2023
f8804ca
remove unnecessary semicolon
gabrywu Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

import java.io.Serializable;
import java.util.List;
import org.apache.beam.sdk.options.PipelineOptions;
import org.apache.beam.sdk.transforms.DoFn;
import org.apache.beam.sdk.values.Row;

/**
Expand All @@ -27,11 +29,17 @@
*/
public interface BeamSqlSeekableTable extends Serializable {
/** prepare the instance. */
default void setUp() {};
default void setUp() {}

default void startBundle(
DoFn<Row, Row>.StartBundleContext context, PipelineOptions pipelineOptions) {}

default void finishBundle(
DoFn<Row, Row>.FinishBundleContext context, PipelineOptions pipelineOptions) {}

/** return a list of {@code Row} with given key set. */
List<Row> seekRow(Row lookupSubRow);

/** cleanup resources of the instance. */
default void tearDown() {};
default void tearDown() {}
}
15 changes: 15 additions & 0 deletions ...l/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamJoinTransforms.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import org.apache.beam.sdk.extensions.sql.impl.utils.SerializableRexFieldAccess;
import org.apache.beam.sdk.extensions.sql.impl.utils.SerializableRexInputRef;
import org.apache.beam.sdk.extensions.sql.impl.utils.SerializableRexNode;
import org.apache.beam.sdk.options.PipelineOptions;
import org.apache.beam.sdk.schemas.FieldAccessDescriptor;
import org.apache.beam.sdk.schemas.Schema;
import org.apache.beam.sdk.transforms.DoFn;
Expand Down Expand Up @@ -155,6 +156,20 @@ public void setup() {
seekableTable.setUp();
}

@StartBundle
public void startBundle(
DoFn<Row, Row>.StartBundleContext context,
PipelineOptions pipelineOptions) {
seekableTable.startBundle(context, pipelineOptions);
}

@FinishBundle
public void finishBundle(
DoFn<Row, Row>.FinishBundleContext context,
PipelineOptions pipelineOptions) {
seekableTable.finishBundle(context, pipelineOptions);
}

@ProcessElement
public void processElement(ProcessContext context) {
Row factRow = context.element();
Expand Down