Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add warnings to file watchers #28206

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Feature/add warnings to file watchers #28206

merged 7 commits into from
Sep 1, 2023

Conversation

johnjcasey
Copy link
Contributor

No description provided.

@johnjcasey johnjcasey marked this pull request as ready for review August 29, 2023 20:09
@github-actions github-actions bot added the java label Aug 29, 2023
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

AnandInguva
AnandInguva reviewed Aug 29, 2023
View reviewed changes
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileIO.java Outdated
*/
public MatchConfiguration continuously(
Duration interval, TerminationCondition<String, ?> condition, boolean matchUpdatedFiles) {
LOG.warn("Matching Continuously is stateful, and can scale poorly. Consider using Pub/Sub "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is true for python sdk as well. If yes, can we add a warning there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@johnjcasey
Copy link
Contributor Author

Run Java PreCommit

@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #28206 (f40345d) into master (7824f2c) will decrease coverage by 0.10%.
Report is 235 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #28206      +/-   ##
==========================================
- Coverage   70.87%   70.78%   -0.10%     
==========================================
  Files         861      865       +4     
  Lines      105010   105459     +449     
==========================================
+ Hits        74422    74644     +222     
- Misses      29030    29257     +227     
  Partials     1558     1558
Flag Coverage Δ
python 79.64% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/apache_beam/io/fileio.py 96.10% <100.00%> (+0.01%) ⬆️

... and 46 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@johnjcasey
Copy link
Contributor Author

The java precommit is an unrelated flake

@m-trieu m-trieu mentioned this pull request Aug 31, 2023
Merged
3 tasks
@johnjcasey
Copy link
Contributor Author

the pending checks all passed as well

@johnjcasey
Copy link
Contributor Author

@AnandInguva ready for another review. It looks like all the failures are flakes

@johnjcasey johnjcasey merged commit 3c93f7d into apache:master Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnandInguva AnandInguva AnandInguva approved these changes

Assignees
No one assigned
Labels
java Next Action: Reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnjcasey @AnandInguva