-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prism] Fail jobs on SDK disconnect. #28193
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Looks like there's a flake with this approach. |
Codecov Report
@@ Coverage Diff @@
## master #28193 +/- ##
==========================================
- Coverage 72.37% 72.34% -0.03%
==========================================
Files 680 680
Lines 100180 100235 +55
==========================================
+ Hits 72506 72520 +14
- Misses 26105 26140 +35
- Partials 1569 1575 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
138b632
to
ceb39d8
Compare
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Jack's out for the weekend. |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
If the control connection for a job is lost, eg. by an SDK worker crash (detected via grpc stream context cancel), then fail all extant instructions, and terminate the job, rather than leave it running perpetually.
Further, ensure the extant bundles are cleaned up from the element manager, to allow failed jobs to be properly garbage collected.
Reduce routine log messages to debug to avoid noise.
Use ctx.WithCancelCause properly, which requires calling context.Cause on the context.
Restructures the bundle processing loop in execute.go to better allow for eager bundle splitting. Would need to move bundle data acquisition to be moved out of stage.Execute, and split there.
Special thanks to the Swift SDK for being in a crashing on worker state to reliably validate this.
Related #28187
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.