-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish SpotBugs Results #28181
Publish SpotBugs Results #28181
Conversation
path: '**/build/reports/spotbugs/*.html' | ||
- name: Publish SpotBugs Results | ||
uses: jwgmeligmeyling/[email protected] | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why there's this code 'if: always()' here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The step will be executed even if the previous steps failed.
@@ -38,7 +38,7 @@ concurrency: | |||
permissions: | |||
actions: write | |||
pull-requests: read | |||
checks: read | |||
checks: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I understand correctly that the write permission is now required for the SpotBugs plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checks: write (allow to add test result to workflow summary page)
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @damccorm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, I added this action to my request to infra - https://issues.apache.org/jira/browse/INFRA-24948
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
|
Infra approved the actions, merging |
Looks like this one didn't get correctly dealt with, followed up in the ticket |
This PR was created to add an action that visualize the results of SpotBugs tests and adds them to the workflow summary page.
The action requires additional permissions:
checks: write (allow to add test result to workflow summary page)
Example runs:
Push: https://github.com/magicgoody/beam/actions/runs/5999348788/job/16270364494
Pull_request_target: https://github.com/magicgoody/beam/actions/runs/5999352471/job/16270381803
Example screenshots:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.