Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prism] Fail pipeline execution properly on descriptor build errors. #28170

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Aug 25, 2023

Add the missing check to trigger pipeline failures at stage construction.

Related to #28126 and #28187


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #28170 (25aaa95) into master (fdf3dfc) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 44.92%.

@@            Coverage Diff             @@
##           master   #28170      +/-   ##
==========================================
- Coverage   72.30%   72.29%   -0.02%     
==========================================
  Files         678      678              
  Lines       99799    99838      +39     
==========================================
+ Hits        72163    72175      +12     
- Misses      26074    26084      +10     
- Partials     1562     1579      +17     
Flag Coverage Δ
go 53.65% <44.92%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...am/runners/prism/internal/engine/elementmanager.go 80.91% <0.00%> (-1.14%) ⬇️
sdks/go/pkg/beam/runners/prism/internal/execute.go 88.11% <22.22%> (-2.65%) ⬇️
sdks/go/pkg/beam/runners/prism/internal/stage.go 83.24% <30.76%> (-2.17%) ⬇️
...go/pkg/beam/runners/prism/internal/handlerunner.go 84.00% <33.33%> (-2.31%) ⬇️
sdks/go/pkg/beam/runners/prism/internal/coders.go 87.97% <63.15%> (-4.08%) ⬇️
...o/pkg/beam/runners/prism/internal/worker/worker.go 48.37% <100.00%> (+1.24%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@byronellis
Copy link
Contributor

LGTM

@lostluck lostluck merged commit e26735d into apache:master Aug 26, 2023
lostluck added a commit to lostluck/beam that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants