Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostCommit Go VR Flink job #28146

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

Amar3tto
Copy link
Contributor

@Amar3tto Amar3tto commented Aug 24, 2023

The following jenkins job has been migrated:

https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink
https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink_PR

How has it been tested?

The job has been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:

  • by adding a comment to the PR

Screenshot from 2023-08-24 14-08-34


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Aug 24, 2023
@Amar3tto Amar3tto marked this pull request as ready for review August 25, 2023 17:23
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

tags: ['v*']
branches: ['master', 'release-*']
paths: ['.github/workflows/beam_PostCommit_Go_VR_Flink.yml']
issue_comment:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the "comment" event? There are no phrase jobs in Jenkins at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was confirmed that we should use dispatch, comment and push triggers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed triggers according to the new information: we need cron, comment and dispatch

@Amar3tto Amar3tto force-pushed the post-commit-go-vr-flink-github-action branch from 767826a to f77bbe4 Compare September 4, 2023 07:28
Copy link
Collaborator

@andreydevyatkin andreydevyatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn Abacn merged commit 06f624b into apache:master Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants