Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup Java for different Java versions. #27863

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Add setup Java for different Java versions. #27863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a37715
Add setup Java for diff Java versions.
celeste-zeng Aug 4, 2023
7345aa0
Add more flags to follow convention.
celeste-zeng Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@ jobs:
requires-py-38: false
requires-py-39: false
requires-go: false
- name: Set up Java${{ matrix.java_version }}
uses: actions/[email protected]
with:
distribution: 'temurin'
java-version: ${{ matrix.java_version }}
- name: Setup Gradle
uses: gradle/gradle-build-action@v2
with:
Expand Down Expand Up @@ -115,6 +120,9 @@ jobs:
-Ppush-containers \
-Pdocker-repository-root=us.gcr.io/apache-beam-testing/github-actions \
-Pdocker-tag=${{env.TAG}} \
-PdisableSpotlessCheck=true \
-PdisableCheckStyle=true \
-PskipCheckerFramework \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have these flags elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference:https://github.com/celeste-zeng/beam/blob/e3d321bc54dca8d258c843566db792cb60967c05/.test-infra/jenkins/job_PostCommit_Java_Examples_Dataflow_V2_Java17.groovy#L47 and here https://github.com/apache/beam/blob/8bd2c97351a4e6f8c6bafd260265d3ca2b7e3673/.github/workflows/beam_PreCommit_Java_Examples_Dataflow_Java11.yml#L105C14-L105C35

- name: Upload test report
uses: actions/upload-artifact@v3
with:
Expand Down