Add PIPELINE_OPTIONS_FILE environment variable to allow PIPELINE_OPTIONS to be read from a file #27841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es the old PIPELINE_OPTIONS environment variable with the contents of a file. This allows us to circumvent kernel limits on the combined size of environment variables and commandline arguments.
3 tasks
lostluck
reviewed
Aug 3, 2023
| PipelineOptionsTranslation.fromJson(environmentVarGetter.apply(PIPELINE_OPTIONS)); | ||
|
|
||
| String pipelineOptionsJson = environmentVarGetter.apply(PIPELINE_OPTIONS); | ||
| // Try looking for a file first. If that exists it should override PIPELINE_OPTIONS to avoid |
There was a problem hiding this comment.
Technically we're not looking for the file first, so I say the comment needs adjusting. Otherwise LGTM.
lostluck
approved these changes
Aug 3, 2023
|
I'm of the opinion that most of the failures are unrelated. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Run Java PreCommit |
|
GitHub Action failures are due to #27854 , not related |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
Run Dataflow ValidatesRunner |
|
Run PortableJar_Flink PostCommit |
|
Run Java Dataflow V2 ValidatesRunner |
bvolpato
reviewed
Aug 8, 2023
| System.out.format("Problem loading pipeline options from file: %s%n", e.getMessage()); | ||
| } | ||
|
|
||
| System.out.format("Pipeline options %s%n", pipelineOptionsJson); |
There was a problem hiding this comment.
Intentionally not using logger?
There was a problem hiding this comment.
Nevermind, I see it just continued the trend from before.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to the FnApi harness PIPELINE_OPTIONS_FILE that overrides the old PIPELINE_OPTIONS environment variable with the contents of a file. This allows us to circumvent kernel limits on the combined size of environment variables and commandl ine arguments.
Addresses #27839
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.