-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#24789] Remainder of changes from #27550. #27822
Conversation
05fb4cb
to
a9474db
Compare
Codecov Report
@@ Coverage Diff @@
## master #27822 +/- ##
==========================================
- Coverage 70.87% 70.87% -0.01%
==========================================
Files 861 861
Lines 104995 105006 +11
==========================================
+ Hits 74419 74426 +7
- Misses 29017 29022 +5
+ Partials 1559 1558 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: Ritesh Ghorse <[email protected]>
I think the failure is a race condition between the logging output and the pipeline shutting down. Good to be aware of at least, for another prism adjustment. |
Remainder of changes from #27550 that have not yet been parceled into smaller CLs for enabling prism as default runner.
See #24789
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.