Add integration tests for streaming Storage Write API (includes schema update feature) #27740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally, we will decide whether to call withSchema() with a schema of shuffled fields based on this option.
* Fix a few typos on the method name STORAGE_WRITE_API * Change the warning message when both numStorageWriteApiStreams and autoSharding are set. In this case, autoSharding takes priority. * Add an argument check for using both numFileShards and autoSharding via FILE_LOADS.
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run Java_GCP_IO_Direct PreCommit |
|
R: @reuvenlax |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
It appears the added test do not work on dataflow runner v1: https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Java_DataflowV1/lastCompletedBuild/testReport/ should all these tests run on dataflow anyways? |
|
Oh - it looks like these tests require streaming engine.
…On Tue, Aug 8, 2023 at 8:54 PM Yi Hu ***@***.***> wrote:
It appears the added test do not work on dataflow runner v1:
https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Java_DataflowV1/lastCompletedBuild/testReport/
should all these tests run on dataflow anyways?
—
Reply to this email directly, view it on GitHub
<#27740 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAYJVNSCX5BBK6QWGW6Y7TXUMCXFANCNFSM6AAAAAA23WQ35E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ahmedabu98
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in continuation of @shunping-google's work in #27213
These are integration tests that write to real BigQuery tables. The test pipeline writes records with a deliberate short timeout between each record so that the Storage API Stream has a chance to recognize the schema update. This PR also adds some warnings when invalid configurations are used (warnings instead of throwing exceptions so as not to break existing workflows. However if we ever do a refactor of this IO, we should turn these warnings into exceptions).
I've opted to not write tests for Batch writes that use the auto schema update feature because that use-case doesn't make much sense. These tests include both
STORAGE_WRITE_APIandSTORAGE_API_AT_LEAST_ONCE, which use StorageApiWritesShardedRecords and StorageApiWriteUnshardedRecord, respectively. Batch writes also use theStorageApiWriteUnshardedRecordtransform, which manages stream appends and schema updates. This is to say that even though we don't have explicit Batch mode tests, that code path is broadly covered with these tests.UPDATE
Had to replace TestStream with PeriodicImpulse in followup: #27998. This is to allow tests to run on TestDataflowRunner