Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Create BigQuery wrapper with pipeline options for ReadAllFromBigQuery #27599

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ahmedabu98
Copy link
Contributor

Like #27583, but for ReadAllFromBigQuery. Haven't seen cases where this read method is used, but including it anyways for completion.

@ahmedabu98
Copy link
Contributor Author

R: @riteshghorse can you look at this one too? its similar to #27583

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #27599 (24b59eb) into master (b54bf52) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #27599      +/-   ##
==========================================
- Coverage   71.12%   71.12%   -0.01%     
==========================================
  Files         860      860              
  Lines      104573   104573              
==========================================
- Hits        74378    74373       -5     
- Misses      28638    28643       +5     
  Partials     1557     1557              
Flag Coverage Δ
python 80.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery.py 70.61% <0.00%> (ø)
...ython/apache_beam/io/gcp/bigquery_read_internal.py 57.69% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@riteshghorse
Copy link
Contributor

Failures are unrelated to this PR. Merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants