Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prism] Universal runner improvements. #27570

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

lostluck
Copy link
Contributor

Improve the universal runner in two key ways to unblock prism adoption.

  • For loopback mode execution, avoid unecessary compile and upload costs when the binary isn't overridded. Uses an empty temporary file. Filed [Task][Go SDK]: Determine canonical local temp directory.  #27569 to have a better canon location for this.
  • Cache the most recent error log from the message stream and report that as the cause of job failure, vs the previous error reporting which was merely "job failed". For runners that actually report job failure messages, this can reduce time for debugging and iteration.

Prism will make use of these, but any portable runner or loopback runner can make use of them. In particular, the message holding replicates what the direct runner can do with failues during its single threaded execution. There are unit tests in the SDK that rely on this behaviour, but it is extremely useful too.

See #27550 and #24789.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #27570 (36bb905) into master (b2e00ef) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #27570      +/-   ##
==========================================
- Coverage   71.14%   71.13%   -0.02%     
==========================================
  Files         861      861              
  Lines      104560   104582      +22     
==========================================
+ Hits        74389    74393       +4     
- Misses      28621    28640      +19     
+ Partials     1550     1549       -1     
Flag Coverage Δ
go 53.63% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...go/pkg/beam/runners/universal/runnerlib/execute.go 0.00% <0.00%> (ø)
...dks/go/pkg/beam/runners/universal/runnerlib/job.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice improvement with loopback mode!

@riteshghorse riteshghorse merged commit fd3f397 into apache:master Jul 20, 2023
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants