Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional context for decoding errors. #27024

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Jun 6, 2023


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the python label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #27024 (414463d) into master (5d6dcee) will increase coverage by 0.05%.
Report is 94 commits behind head on master.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #27024      +/-   ##
==========================================
+ Coverage   72.21%   72.27%   +0.05%     
==========================================
  Files         684      686       +2     
  Lines      101241   101153      -88     
==========================================
- Hits        73116    73112       -4     
+ Misses      26546    26494      -52     
+ Partials     1579     1547      -32     
Flag Coverage Δ
python 82.62% <50.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hon/apache_beam/runners/worker/bundle_processor.py 94.01% <50.00%> (-0.22%) ⬇️

... and 83 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 5, 2023
@robertwb
Copy link
Contributor Author

robertwb commented Aug 7, 2023

R: @AnandInguva

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@github-actions github-actions bot removed the stale label Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 8, 2023
Copy link
Contributor

@AnandInguva AnandInguva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I was OOO that time and I might have missed it.

@github-actions github-actions bot removed the stale label Oct 9, 2023
@robertwb
Copy link
Contributor Author

robertwb commented Oct 9, 2023

Run PythonLint PreCommit

@robertwb robertwb merged commit f63e9ed into apache:master Oct 9, 2023
@AnandInguva
Copy link
Contributor

AnandInguva commented Oct 10, 2023

https://github.com/apache/beam/actions/runs/6461486495/job/17563107807?pr=26307 - this was breaking lint. The lint might not have run due to GHA queue and not getting showed at the tests tab - #28909

I will provide a forward fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants