Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small release fixes #26530

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented May 3, 2023

This does 2 things:

  1. Prompts for confirmation before running the java artifact validation (this should save time)
  2. Undoes the changes from bc4ee85 which caused artifacts to be staged to dist.apache.org with an _rcX appended to them

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label May 3, 2023
@damccorm
Copy link
Contributor Author

damccorm commented May 3, 2023

R: @jrmccluskey

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #26530 (73ecd06) into master (a13749f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26530      +/-   ##
==========================================
+ Coverage   81.11%   81.13%   +0.01%     
==========================================
  Files         469      469              
  Lines       67438    67438              
==========================================
+ Hits        54705    54713       +8     
+ Misses      12733    12725       -8     
Flag Coverage Δ
python 81.13% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor Author

damccorm commented May 3, 2023

Run Go PreCommit

@damccorm
Copy link
Contributor Author

damccorm commented May 3, 2023

Run Java PreCommit

@damccorm damccorm merged commit 03ecb15 into apache:master May 3, 2023
@damccorm damccorm deleted the users/damccorm/releaseNits branch May 3, 2023 20:51
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants