Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the lower bound of protobuf. #26446

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Apr 27, 2023

Lower the lower bound of protobuf. Requested by TFX


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #26446 (a4e7411) into master (f770c9b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26446      +/-   ##
==========================================
- Coverage   81.12%   81.10%   -0.03%     
==========================================
  Files         469      469              
  Lines       67294    67294              
==========================================
- Hits        54590    54576      -14     
- Misses      12704    12718      +14     
Flag Coverage Δ
python 81.10% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/setup.py 0.00% <ø> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguva AnandInguva changed the title Lower the lower bound of protobuf and also adjust dependencies in build-requirements.txt Lower the lower bound of protobuf. Apr 27, 2023
@AnandInguva
Copy link
Contributor Author

Run Python 3.10 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.11 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.7 PostCommit

@AnandInguva AnandInguva requested a review from tvalentyn April 27, 2023 03:58
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AnandInguva AnandInguva merged commit 261a69a into apache:master Apr 27, 2023
AnandInguva added a commit to AnandInguva/beam that referenced this pull request Apr 27, 2023
Lower the lower bound of protobuf to 3.20.3.
jrmccluskey pushed a commit that referenced this pull request May 1, 2023
Lower the lower bound of protobuf to 3.20.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants