Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS2] Bump AWS v2 SDK #26380

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[AWS2] Bump AWS v2 SDK #26380

merged 1 commit into from
Apr 25, 2023

Conversation

mosche
Copy link
Member

@mosche mosche commented Apr 21, 2023

Bump AWS SDK v2 to latest.
This also fixes a bug in ProfileCredentialsProvider that made the behavior rather indeterministic when providing a custom profile name. See test changes below.

(closes #26323)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@mosche
Copy link
Member Author

mosche commented Apr 21, 2023

R: @aromanenko-dev
R: @psolomin

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@apache apache deleted a comment from codecov bot Apr 21, 2023
@mosche
Copy link
Member Author

mosche commented Apr 21, 2023

retest this please

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #26380 (f1bd768) into master (2c6a215) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26380      +/-   ##
==========================================
- Coverage   81.09%   81.08%   -0.02%     
==========================================
  Files         469      469              
  Lines       67184    67291     +107     
==========================================
+ Hits        54486    54562      +76     
- Misses      12698    12729      +31     
Flag Coverage Δ
python 81.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/setup.py 0.00% <ø> (ø)

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@psolomin psolomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've compared dependency trees and did not see anything which would ring a bell.

However, when I reset AwsModule.java to the version from master branch, the tests from your version still pass. Is that intended? Just wonder if some tests are missing.

@mosche
Copy link
Member Author

mosche commented Apr 25, 2023

However, when I reset AwsModule.java to the version from master branch, the tests from your version still pass. Is that intended? Just wonder if some tests are missing.

The code removed in AwsModule is more or less irrelevant, that's just to log a warning to catch a bug in the older SDK version. If you reset the tests to master you will see some failures because initialization of the provider was changed to lazy init when first loading credentials.

@mosche
Copy link
Member Author

mosche commented Apr 25, 2023

Retest this please

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@psolomin psolomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are referring to this change? aws/aws-sdk-java-v2@1fafd9e

It's clear now, thanks for clarifying 👍

@mosche mosche merged commit 7a060c5 into apache:master Apr 25, 2023
@mosche mosche deleted the 26323-bump-aws2 branch April 25, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Bump AWS 2 SDK version
3 participants