-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS2] Bump AWS v2 SDK #26380
[AWS2] Bump AWS v2 SDK #26380
Conversation
R: @aromanenko-dev |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
retest this please |
Codecov Report
@@ Coverage Diff @@
## master #26380 +/- ##
==========================================
- Coverage 81.09% 81.08% -0.02%
==========================================
Files 469 469
Lines 67184 67291 +107
==========================================
+ Hits 54486 54562 +76
- Misses 12698 12729 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've compared dependency trees and did not see anything which would ring a bell.
However, when I reset AwsModule.java
to the version from master
branch, the tests from your version still pass. Is that intended? Just wonder if some tests are missing.
The code removed in AwsModule is more or less irrelevant, that's just to log a warning to catch a bug in the older SDK version. If you reset the tests to master you will see some failures because initialization of the provider was changed to lazy init when first loading credentials. |
Retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you are referring to this change? aws/aws-sdk-java-v2@1fafd9e
It's clear now, thanks for clarifying 👍
Bump AWS SDK v2 to latest.
This also fixes a bug in ProfileCredentialsProvider that made the behavior rather indeterministic when providing a custom profile name. See test changes below.
(closes #26323)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.