Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chromedriver-binary requirement from <113,>=100 to >=100,<114 in /sdks/python #26252

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 13, 2023

Updates the requirements on chromedriver-binary to permit the latest version.

Commits
  • 8eb434e Chromedriver version 113.0.5672.24
  • bd73281 Chromedriver version 112.0.5615.49
  • a028952 Chromedriver version 112.0.5615.28
  • 84feb0c Chromedriver version 111.0.5563.64
  • fccd70c Chromedriver version 111.0.5563.41
  • 92d4df4 Chromedriver version 111.0.5563.19
  • b0c3a4b Chromedriver version 110.0.5481.77
  • 7e07511 Chromedriver version 110.0.5481.30
  • 1f7339c Chromedriver version 109.0.5414.74
  • 25e8751 Chromedriver version 109.0.5414.25
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [chromedriver-binary](https://github.com/danielkaiser/python-chromedriver-binary) to permit the latest version.
- [Release notes](https://github.com/danielkaiser/python-chromedriver-binary/releases)
- [Commits](danielkaiser/python-chromedriver-binary@v100.0.4896.20.0...v113.0.5672.24.0)

---
updated-dependencies:
- dependency-name: chromedriver-binary
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python labels Apr 13, 2023
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @AnandInguva

@AnandInguva
Copy link
Contributor

Run Python_Coverage PreCommit

@AnandInguva
Copy link
Contributor

Run Python_Runners PreCommit

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #26252 (c8b0bde) into master (e0e1398) will increase coverage by 0.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #26252      +/-   ##
==========================================
+ Coverage   71.21%   71.86%   +0.65%     
==========================================
  Files         787      752      -35     
  Lines      103330   101477    -1853     
==========================================
- Hits        73588    72928     -660     
+ Misses      28246    27053    -1193     
  Partials     1496     1496              
Flag Coverage Δ
python 81.06% <ø> (+1.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/textio.py 94.89% <ø> (ø)
sdks/python/setup.py 0.00% <ø> (ø)

... and 48 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @AnandInguva

@AnandInguva AnandInguva merged commit dfaab2b into master Apr 28, 2023
@dependabot dependabot bot deleted the dependabot/pip/sdks/python/chromedriver-binary-gte-100-and-lt-114 branch April 28, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Next Action: Reviewers python slow-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant