Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure truncate element is wrapped in *FullValue #25908

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Ensure truncate element is wrapped in *FullValue #25908

merged 1 commit into from
Mar 20, 2023

Conversation

lostluck
Copy link
Contributor

Ensure we're always providing the correct inputs on Truncate restrictions for drains.

Update the test to provide a correct example of a draining DoFn. Add logging to help validate progress.

Test remains having a manual drain however, so it remains filtered until programmatic drain is supported.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #25908 (9ae98ff) into master (b5ce110) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #25908      +/-   ##
==========================================
- Coverage   71.41%   71.41%   -0.01%     
==========================================
  Files         778      778              
  Lines      102379   102374       -5     
==========================================
- Hits        73112    73108       -4     
  Misses      27811    27811              
+ Partials     1456     1455       -1     
Flag Coverage Δ
go 53.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/exec/sdf.go 65.81% <100.00%> (-0.31%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lostluck
Copy link
Contributor Author

lostluck commented Mar 20, 2023

R: @hnnsgstfssn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@hnnsgstfssn hnnsgstfssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and have verified that this change does indeed allow the example in #25808 to run and successfully drain. Thanks!

@lostluck
Copy link
Contributor Author

Excellent! Merging.

@lostluck lostluck marked this pull request as ready for review March 20, 2023 23:40
@lostluck lostluck merged commit 6cb7b8e into master Mar 20, 2023
@lostluck lostluck deleted the drainFix branch April 12, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants