Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the cord ctype for proto generation, where available. #25802

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

robertwb
Copy link
Contributor

This is natural as this field is often large and composed of the concatenation of many small elements, which can lead to significant performance improvements.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

This is natural as this field is often large and composed of
the concatenation of many small elements, which can lead to
significant performance improvements.
@robertwb
Copy link
Contributor Author

R: @melaniedc

@github-actions github-actions bot added the model label Mar 10, 2023
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #25802 (6746fbe) into master (b1ea4d3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25802   +/-   ##
=======================================
  Coverage   72.80%   72.81%           
=======================================
  Files         775      775           
  Lines      102948   102949    +1     
=======================================
+ Hits        74956    74963    +7     
+ Misses      26537    26531    -6     
  Partials     1455     1455           
Flag Coverage Δ
python 81.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@melaniedc melaniedc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@robertwb robertwb merged commit 8c90c64 into apache:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants